fix: Cannot get GLFW version in compiled apps?#190
fix: Cannot get GLFW version in compiled apps?#190sairus7 merged 3 commits intoJuliaImGui:masterfrom
Conversation
|
Just to confirm, does PackageCompiler work with this change? |
|
Didn't check yet. |
|
Ok, I think it'd be good to check that first before we tag a new release. |
|
Is this tested and ready to merge? |
|
Not yet, I will ping you here once I reach to compile an app. Are you waiting for this to merge before some other changes? |
|
Nope no rush, just didn't want to leave it hanging in case it's ready 🙂 |
|
I can confirm it works in portable way on Windows. If you compile old code version and run on the same machine, it somehow bakes path to your dev environment |
|
So I think it can be merged. Theoretically there can be an issue when you precompile and save CImGui module (and bake GLFW version with it), then change GLFW version, then load CImGui from precompiled image. |
JamesWrigley
left a comment
There was a problem hiding this comment.
Forgot to mention, could you add a changelog entry?
Fixes #187