Skip to content

fix: Cannot get GLFW version in compiled apps?#190

Merged
sairus7 merged 3 commits intoJuliaImGui:masterfrom
sairus7:master
Jan 16, 2026
Merged

fix: Cannot get GLFW version in compiled apps?#190
sairus7 merged 3 commits intoJuliaImGui:masterfrom
sairus7:master

Conversation

@sairus7
Copy link
Collaborator

@sairus7 sairus7 commented Jan 12, 2026

Fixes #187

@JamesWrigley
Copy link
Member

Just to confirm, does PackageCompiler work with this change?

@sairus7
Copy link
Collaborator Author

sairus7 commented Jan 12, 2026

Didn't check yet.

@JamesWrigley
Copy link
Member

Ok, I think it'd be good to check that first before we tag a new release.

@JamesWrigley
Copy link
Member

Is this tested and ready to merge?

@sairus7
Copy link
Collaborator Author

sairus7 commented Jan 14, 2026

Not yet, I will ping you here once I reach to compile an app. Are you waiting for this to merge before some other changes?

@JamesWrigley
Copy link
Member

Nope no rush, just didn't want to leave it hanging in case it's ready 🙂

@sairus7
Copy link
Collaborator Author

sairus7 commented Jan 16, 2026

I can confirm it works in portable way on Windows. If you compile old code version and run on the same machine, it somehow bakes path to your dev environment Project.toml file and doesn't fail. So it only fail when moving executable to other machine. With this change it doesn't fail on other machine, because pkgversion is evaluated and baked at module precompilation.

@sairus7
Copy link
Collaborator Author

sairus7 commented Jan 16, 2026

So I think it can be merged.

Theoretically there can be an issue when you precompile and save CImGui module (and bake GLFW version with it), then change GLFW version, then load CImGui from precompiled image.

Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to mention, could you add a changelog entry?

Copy link
Member

@JamesWrigley JamesWrigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sairus7 sairus7 merged commit 102b6d3 into JuliaImGui:master Jan 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot get GLFW version in compiled apps?

2 participants